Compare commits
1 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 4e3f6aa94e |
@@ -5,6 +5,18 @@ All notable changes to RigDoctor are recorded here. Format follows
|
|||||||
(`MAJOR.MINOR.PATCH`, pre-1.0). `__version__` and `pyproject.toml` must match the git
|
(`MAJOR.MINOR.PATCH`, pre-1.0). `__version__` and `pyproject.toml` must match the git
|
||||||
release tag (so the auto-updater, D18, can compare versions).
|
release tag (so the auto-updater, D18, can compare versions).
|
||||||
|
|
||||||
|
## [0.0.6] - 2026-05-21
|
||||||
|
### Added
|
||||||
|
- **Token-gated updates (M13)**: store a Gitea Personal Access Token, **encrypted in the OS
|
||||||
|
keyring** (Secret Service / GNOME Keyring via `secret-tool`) with a 0600-file fallback.
|
||||||
|
`rigdoctor login` / `logout` / `update [--check]`; GUI **Setup → Update access** panel
|
||||||
|
(token field, "Get a token", backend status) and sidebar states (connect / up-to-date /
|
||||||
|
"Update to v…" / access denied). Updates are gated to accounts on the Gitea server (D18).
|
||||||
|
- `libsecret-tools` added to the installer catalog (enables encrypted token storage).
|
||||||
|
### Changed
|
||||||
|
- D18 update mechanism revised from anonymous public HTTP to **authenticated HTTP (token)** —
|
||||||
|
the Gitea instance requires sign-in for all anonymous access.
|
||||||
|
|
||||||
## [0.0.5] - 2026-05-21
|
## [0.0.5] - 2026-05-21
|
||||||
### Added
|
### Added
|
||||||
- **M9 installer (first cut)**: detects distro / package manager / GPU; a catalog of optional
|
- **M9 installer (first cut)**: detects distro / package manager / GPU; a catalog of optional
|
||||||
|
|||||||
+15
-2
@@ -152,9 +152,22 @@ reachable from it. This **supersedes the earlier "CLI-first / terminal-first" fr
|
|||||||
- *No change to layering (D2):* the core, CLI, and daemon stay **stdlib-only** and must run
|
- *No change to layering (D2):* the core, CLI, and daemon stay **stdlib-only** and must run
|
||||||
without Qt. "GUI-first" is about emphasis and front-end parity, not dropping headless support.
|
without Qt. "GUI-first" is about emphasis and front-end parity, not dropping headless support.
|
||||||
|
|
||||||
### D18 — Auto-update (M13) — *PLANNED 2026-05-21*
|
### D18 — Auto-update (M13) — *PLANNED 2026-05-21; mechanism revised 2026-05-21*
|
||||||
RigDoctor should **check for a newer version on launch and self-update** (new module **M13**).
|
RigDoctor should **check for a newer version on launch and self-update** (new module **M13**).
|
||||||
**Mechanism (chosen): user-local, no-root self-update from the public repo.**
|
**Mechanism (revised): user-local, no-root self-update over authenticated HTTP (token).**
|
||||||
|
*Why revised:* the Gitea instance requires sign-in for **all** anonymous access (repo page,
|
||||||
|
releases feed, raw, API all 303/403 anonymously), so the original "public HTTP" plan can't
|
||||||
|
work. Updates are therefore **gated to people with an account on the Gitea server**, which is
|
||||||
|
desirable — access control is delegated to Gitea.
|
||||||
|
- *Auth:* each user creates a **Personal Access Token** (scope `read:repository`); RigDoctor
|
||||||
|
stores it at `~/.config/rigdoctor/token` (mode 0600) or reads `RIGDOCTOR_TOKEN`. Requests
|
||||||
|
send `Authorization: token <PAT>`. Finer access = repo visibility/collaborators on Gitea.
|
||||||
|
- *Check:* `GET /api/v1/repos/jessey/rigdoctor/releases/latest` with the token; compare tags.
|
||||||
|
- *Apply:* `pip install --upgrade "git+https://oauth2:<token>@…/rigdoctor.git@<tag>"` into the
|
||||||
|
user-local venv, then restart (incl. the daemon). No root.
|
||||||
|
- *States surfaced:* no-token → "connect to update server"; auth error → "access denied";
|
||||||
|
newer → "Update to v…"; else "up-to-date".
|
||||||
|
- *Original (now-superseded) plan was anonymous public HTTP:*
|
||||||
- *Install model (D8 revised):* primary install is **user-local** (`~/.local`), so the running
|
- *Install model (D8 revised):* primary install is **user-local** (`~/.local`), so the running
|
||||||
app can replace its own files and update with **no apt, no root, no password prompt**.
|
app can replace its own files and update with **no apt, no root, no password prompt**.
|
||||||
- *Check:* on launch, query the **public Gitea releases API**
|
- *Check:* on launch, query the **public Gitea releases API**
|
||||||
|
|||||||
+6
-4
@@ -64,10 +64,12 @@ Status: ⬜ not started · 🟦 designing · 🟨 in progress · ✅ done
|
|||||||
no hosted relay), (3) **gated interactive terminal** wrapping tmate/sshx (read-only by
|
no hosted relay), (3) **gated interactive terminal** wrapping tmate/sshx (read-only by
|
||||||
default; read-write only on explicit consent — a deliberate exception to D9). Per-session
|
default; read-write only on explicit consent — a deliberate exception to D9). Per-session
|
||||||
consent, ephemeral revocable tokens, audit log.
|
consent, ephemeral revocable tokens, audit log.
|
||||||
- **M13 Auto-update** (D18) — *check half implemented:* on GUI launch, `core/updates` queries
|
- **M13 Auto-update** (D18) — *check + auth implemented:* updates are **gated to Gitea account
|
||||||
the Gitea releases API and the sidebar shows up-to-date / an "Update to v…" button / "update
|
holders** via a Personal Access Token, stored **encrypted in the OS keyring** (`secret-tool`)
|
||||||
check unavailable" (the instance currently requires sign-in for anonymous API calls). The
|
with a 0600-file fallback (`config.load_token`/`save_token`/`token_backend`). `core/updates`
|
||||||
no-root **self-update** (download → verify → atomic swap → restart) is still pending.
|
queries the releases API with the token; CLI `login`/`logout`/`update`; GUI Setup "Update
|
||||||
|
access" panel + sidebar states. The no-root **self-update apply** (download → verify → swap →
|
||||||
|
restart) and the user-local install script are still pending.
|
||||||
*Original plan:* On launch, check the public Gitea releases API and
|
*Original plan:* On launch, check the public Gitea releases API and
|
||||||
**self-update a user-local install with no root** (download → verify checksum/signature →
|
**self-update a user-local install with no root** (download → verify checksum/signature →
|
||||||
atomic symlink swap → restart, incl. the daemon). HTTPS-only, version-check-only (no
|
atomic symlink swap → restart, incl. the daemon). HTTPS-only, version-check-only (no
|
||||||
|
|||||||
+1
-1
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
|
|||||||
|
|
||||||
[project]
|
[project]
|
||||||
name = "rigdoctor"
|
name = "rigdoctor"
|
||||||
version = "0.0.5"
|
version = "0.0.6"
|
||||||
description = "Modular hardware monitoring & crash diagnostics for Linux gamers."
|
description = "Modular hardware monitoring & crash diagnostics for Linux gamers."
|
||||||
readme = "README.md"
|
readme = "README.md"
|
||||||
requires-python = ">=3.11"
|
requires-python = ">=3.11"
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
"""RigDoctor — modular hardware monitoring & crash diagnostics for Linux gamers."""
|
"""RigDoctor — modular hardware monitoring & crash diagnostics for Linux gamers."""
|
||||||
|
|
||||||
__version__ = "0.0.5"
|
__version__ = "0.0.6"
|
||||||
|
|||||||
@@ -212,6 +212,64 @@ def cmd_install(args) -> int:
|
|||||||
return rc
|
return rc
|
||||||
|
|
||||||
|
|
||||||
|
def cmd_login(args) -> int:
|
||||||
|
from getpass import getpass
|
||||||
|
|
||||||
|
from .core import updates
|
||||||
|
|
||||||
|
token = args.token
|
||||||
|
if not token:
|
||||||
|
print(f"Create a token (scope read:repository) at: {updates.TOKEN_PAGE}")
|
||||||
|
try:
|
||||||
|
token = getpass("Paste token: ").strip()
|
||||||
|
except (EOFError, KeyboardInterrupt):
|
||||||
|
token = ""
|
||||||
|
if not token:
|
||||||
|
print("No token provided.")
|
||||||
|
return 1
|
||||||
|
config.save_token(token)
|
||||||
|
state, tag = updates.update_state()
|
||||||
|
if state == updates.AUTH:
|
||||||
|
print("Token saved, but the server rejected it (check scope/permissions).")
|
||||||
|
return 1
|
||||||
|
if state in (updates.UP_TO_DATE, updates.AVAILABLE):
|
||||||
|
print(f"Token saved and verified. Latest release: {tag}.")
|
||||||
|
return 0
|
||||||
|
print("Token saved (couldn't reach the server to verify right now).")
|
||||||
|
return 0
|
||||||
|
|
||||||
|
|
||||||
|
def cmd_logout(args) -> int:
|
||||||
|
config.clear_token()
|
||||||
|
print("Update token removed.")
|
||||||
|
return 0
|
||||||
|
|
||||||
|
|
||||||
|
def cmd_update(args) -> int:
|
||||||
|
from .core import updates
|
||||||
|
|
||||||
|
state, tag = updates.update_state()
|
||||||
|
if state == updates.NO_TOKEN:
|
||||||
|
print("No update token. Run `rigdoctor login` after creating one at:")
|
||||||
|
print(f" {updates.TOKEN_PAGE}")
|
||||||
|
return 1
|
||||||
|
if state == updates.AUTH:
|
||||||
|
print("The update server rejected your token (check scope/permissions).")
|
||||||
|
return 1
|
||||||
|
if state == updates.NETWORK:
|
||||||
|
print("Couldn't reach the update server.")
|
||||||
|
return 1
|
||||||
|
if state == updates.UP_TO_DATE:
|
||||||
|
print(f"Up to date (v{__version__}).")
|
||||||
|
return 0
|
||||||
|
# AVAILABLE
|
||||||
|
print(f"Update available: {tag} (current v{__version__}).")
|
||||||
|
if args.check:
|
||||||
|
return 0
|
||||||
|
print("Self-update (apply) isn't wired yet — coming with the install script.")
|
||||||
|
return 0
|
||||||
|
|
||||||
|
|
||||||
def cmd_report(args) -> int:
|
def cmd_report(args) -> int:
|
||||||
from dataclasses import asdict
|
from dataclasses import asdict
|
||||||
|
|
||||||
@@ -250,6 +308,15 @@ def build_parser() -> argparse.ArgumentParser:
|
|||||||
inst.add_argument("-y", "--yes", action="store_true", help="install without confirmation")
|
inst.add_argument("-y", "--yes", action="store_true", help="install without confirmation")
|
||||||
inst.set_defaults(func=cmd_install)
|
inst.set_defaults(func=cmd_install)
|
||||||
|
|
||||||
|
login = sub.add_parser("login", help="save a Gitea token for updates (M13)")
|
||||||
|
login.add_argument("--token", default=None, help="token (prompted if omitted)")
|
||||||
|
login.set_defaults(func=cmd_login)
|
||||||
|
sub.add_parser("logout", help="remove the saved update token").set_defaults(func=cmd_logout)
|
||||||
|
|
||||||
|
upd = sub.add_parser("update", help="check for / apply a newer version (M13)")
|
||||||
|
upd.add_argument("--check", action="store_true", help="only report, don't apply")
|
||||||
|
upd.set_defaults(func=cmd_update)
|
||||||
|
|
||||||
rec = sub.add_parser("record", help="crash-capture logger (M3)")
|
rec = sub.add_parser("record", help="crash-capture logger (M3)")
|
||||||
rec_sub = rec.add_subparsers(dest="record_cmd", required=True)
|
rec_sub = rec.add_subparsers(dest="record_cmd", required=True)
|
||||||
|
|
||||||
|
|||||||
@@ -3,6 +3,8 @@
|
|||||||
from __future__ import annotations
|
from __future__ import annotations
|
||||||
|
|
||||||
import os
|
import os
|
||||||
|
import shutil
|
||||||
|
import subprocess
|
||||||
from pathlib import Path
|
from pathlib import Path
|
||||||
|
|
||||||
APP = "rigdoctor"
|
APP = "rigdoctor"
|
||||||
@@ -25,6 +27,112 @@ STATUS_FILE = STATE_DIR / "recorder.json"
|
|||||||
PID_FILE = STATE_DIR / "recorder.pid"
|
PID_FILE = STATE_DIR / "recorder.pid"
|
||||||
SPAWN_LOG = STATE_DIR / "recorder.out"
|
SPAWN_LOG = STATE_DIR / "recorder.out"
|
||||||
|
|
||||||
|
# Update access token (M13) — gates updates to Gitea account holders (D18).
|
||||||
|
# Stored in the OS keyring (Secret Service / GNOME Keyring) via `secret-tool` when
|
||||||
|
# available — encrypted at rest, unlocked with the login session — else a 0600 file.
|
||||||
|
TOKEN_FILE = CONFIG_DIR / "token"
|
||||||
|
_SECRET_ATTRS = ["application", "rigdoctor", "type", "update-token"]
|
||||||
|
|
||||||
|
|
||||||
|
def _secret_tool() -> str | None:
|
||||||
|
return shutil.which("secret-tool")
|
||||||
|
|
||||||
|
|
||||||
|
def keyring_available() -> bool:
|
||||||
|
"""True if an encrypted OS keyring (secret-tool) is usable."""
|
||||||
|
return _secret_tool() is not None
|
||||||
|
|
||||||
|
|
||||||
|
def _keyring_store(token: str) -> bool:
|
||||||
|
tool = _secret_tool()
|
||||||
|
if not tool:
|
||||||
|
return False
|
||||||
|
try:
|
||||||
|
proc = subprocess.run(
|
||||||
|
[tool, "store", "--label", "RigDoctor update token", *_SECRET_ATTRS],
|
||||||
|
input=token, text=True, capture_output=True, timeout=20,
|
||||||
|
)
|
||||||
|
return proc.returncode == 0
|
||||||
|
except (subprocess.SubprocessError, OSError):
|
||||||
|
return False
|
||||||
|
|
||||||
|
|
||||||
|
def _keyring_lookup() -> str | None:
|
||||||
|
tool = _secret_tool()
|
||||||
|
if not tool:
|
||||||
|
return None
|
||||||
|
try:
|
||||||
|
proc = subprocess.run(
|
||||||
|
[tool, "lookup", *_SECRET_ATTRS], text=True, capture_output=True, timeout=20
|
||||||
|
)
|
||||||
|
if proc.returncode == 0 and proc.stdout.strip():
|
||||||
|
return proc.stdout.strip()
|
||||||
|
except (subprocess.SubprocessError, OSError):
|
||||||
|
pass
|
||||||
|
return None
|
||||||
|
|
||||||
|
|
||||||
|
def _keyring_clear() -> None:
|
||||||
|
tool = _secret_tool()
|
||||||
|
if not tool:
|
||||||
|
return
|
||||||
|
try:
|
||||||
|
subprocess.run([tool, "clear", *_SECRET_ATTRS], capture_output=True, timeout=20)
|
||||||
|
except (subprocess.SubprocessError, OSError):
|
||||||
|
pass
|
||||||
|
|
||||||
|
|
||||||
|
def load_token() -> str | None:
|
||||||
|
"""Token from $RIGDOCTOR_TOKEN, then the OS keyring, then a 0600 file."""
|
||||||
|
env = os.environ.get("RIGDOCTOR_TOKEN")
|
||||||
|
if env and env.strip():
|
||||||
|
return env.strip()
|
||||||
|
from_keyring = _keyring_lookup()
|
||||||
|
if from_keyring:
|
||||||
|
return from_keyring
|
||||||
|
try:
|
||||||
|
token = TOKEN_FILE.read_text().strip()
|
||||||
|
return token or None
|
||||||
|
except OSError:
|
||||||
|
return None
|
||||||
|
|
||||||
|
|
||||||
|
def save_token(token: str) -> None:
|
||||||
|
"""Save to the OS keyring if possible (encrypted); else a 0600 file."""
|
||||||
|
token = token.strip()
|
||||||
|
if _keyring_store(token):
|
||||||
|
try: # don't leave a plaintext copy once it's in the keyring
|
||||||
|
TOKEN_FILE.unlink()
|
||||||
|
except OSError:
|
||||||
|
pass
|
||||||
|
return
|
||||||
|
CONFIG_DIR.mkdir(parents=True, exist_ok=True)
|
||||||
|
TOKEN_FILE.write_text(token + "\n")
|
||||||
|
try:
|
||||||
|
TOKEN_FILE.chmod(0o600)
|
||||||
|
except OSError:
|
||||||
|
pass
|
||||||
|
|
||||||
|
|
||||||
|
def clear_token() -> None:
|
||||||
|
_keyring_clear()
|
||||||
|
try:
|
||||||
|
TOKEN_FILE.unlink()
|
||||||
|
except OSError:
|
||||||
|
pass
|
||||||
|
|
||||||
|
|
||||||
|
def token_backend() -> str:
|
||||||
|
"""Where the active token lives: 'env' | 'keyring' | 'file' | 'none'."""
|
||||||
|
env = os.environ.get("RIGDOCTOR_TOKEN")
|
||||||
|
if env and env.strip():
|
||||||
|
return "env"
|
||||||
|
if _keyring_lookup() is not None:
|
||||||
|
return "keyring"
|
||||||
|
if TOKEN_FILE.exists():
|
||||||
|
return "file"
|
||||||
|
return "none"
|
||||||
|
|
||||||
DEFAULTS: dict = {
|
DEFAULTS: dict = {
|
||||||
"interval": 1.0, # sampling interval in seconds (default ≤1 Hz — NFR)
|
"interval": 1.0, # sampling interval in seconds (default ≤1 Hz — NFR)
|
||||||
"log_max_bytes": 20_000_000, # rotate a log segment past this size
|
"log_max_bytes": 20_000_000, # rotate a log segment past this size
|
||||||
|
|||||||
@@ -41,4 +41,8 @@ COMPONENTS: tuple[Component, ...] = (
|
|||||||
"libnotify", "Desktop notifications", "Monitoring",
|
"libnotify", "Desktop notifications", "Monitoring",
|
||||||
"Desktop alert notifications (M8)", ("libnotify-bin",), "notify-send",
|
"Desktop alert notifications (M8)", ("libnotify-bin",), "notify-send",
|
||||||
),
|
),
|
||||||
|
Component(
|
||||||
|
"libsecret", "Encrypted token storage", "Updates",
|
||||||
|
"Store the update token in the OS keyring, encrypted (M13)", ("libsecret-tools",), "secret-tool",
|
||||||
|
),
|
||||||
)
|
)
|
||||||
|
|||||||
@@ -1,21 +1,32 @@
|
|||||||
"""Update check (M13, check half): ask the Gitea releases API for the latest version.
|
"""Update check (M13): ask the Gitea releases API for the latest version.
|
||||||
|
|
||||||
Stdlib-only (urllib). Self-update isn't built yet; this only *detects* a newer
|
Stdlib-only (urllib). The Gitea instance requires sign-in, so updates are gated to
|
||||||
release. Any failure (network, or the instance requiring sign-in for the API)
|
account holders via a Personal Access Token (D18): set $RIGDOCTOR_TOKEN or save one
|
||||||
returns None so callers can degrade gracefully.
|
with `rigdoctor login`. Self-update (apply) is built on top of this; this module
|
||||||
|
handles detection and exposes a clear state for the UI.
|
||||||
"""
|
"""
|
||||||
|
|
||||||
from __future__ import annotations
|
from __future__ import annotations
|
||||||
|
|
||||||
import json
|
import json
|
||||||
|
import urllib.error
|
||||||
import urllib.request
|
import urllib.request
|
||||||
|
|
||||||
from .. import __version__
|
from .. import __version__
|
||||||
|
from ..config import load_token
|
||||||
|
|
||||||
GITEA_BASE = "https://git.jesseyvanofferen.com"
|
GITEA_BASE = "https://git.jesseyvanofferen.com"
|
||||||
REPO = "jessey/rigdoctor"
|
REPO = "jessey/rigdoctor"
|
||||||
LATEST_API = f"{GITEA_BASE}/api/v1/repos/{REPO}/releases/latest"
|
LATEST_API = f"{GITEA_BASE}/api/v1/repos/{REPO}/releases/latest"
|
||||||
RELEASES_PAGE = f"{GITEA_BASE}/{REPO}/releases"
|
RELEASES_PAGE = f"{GITEA_BASE}/{REPO}/releases"
|
||||||
|
TOKEN_PAGE = f"{GITEA_BASE}/user/settings/applications"
|
||||||
|
|
||||||
|
# Update states
|
||||||
|
NO_TOKEN = "no-token"
|
||||||
|
AUTH = "auth"
|
||||||
|
NETWORK = "network"
|
||||||
|
UP_TO_DATE = "up-to-date"
|
||||||
|
AVAILABLE = "available"
|
||||||
|
|
||||||
|
|
||||||
def _parse(version: str) -> tuple[int, ...]:
|
def _parse(version: str) -> tuple[int, ...]:
|
||||||
@@ -29,13 +40,36 @@ def is_newer(latest: str, current: str = __version__) -> bool:
|
|||||||
return False
|
return False
|
||||||
|
|
||||||
|
|
||||||
def check_latest(timeout: float = 4.0) -> str | None:
|
def fetch_latest(timeout: float = 5.0) -> tuple[str | None, str | None]:
|
||||||
"""Return the latest release tag (e.g. 'v0.0.5'), or None if it can't be determined."""
|
"""Return (tag, error). error is one of NO_TOKEN / AUTH / NETWORK, or None on success."""
|
||||||
|
token = load_token()
|
||||||
|
if not token:
|
||||||
|
return (None, NO_TOKEN)
|
||||||
|
req = urllib.request.Request(
|
||||||
|
LATEST_API,
|
||||||
|
headers={"Accept": "application/json", "Authorization": f"token {token}"},
|
||||||
|
)
|
||||||
try:
|
try:
|
||||||
req = urllib.request.Request(LATEST_API, headers={"Accept": "application/json"})
|
with urllib.request.urlopen(req, timeout=timeout) as resp: # noqa: S310 (https)
|
||||||
with urllib.request.urlopen(req, timeout=timeout) as resp: # noqa: S310 (https only)
|
|
||||||
data = json.load(resp)
|
data = json.load(resp)
|
||||||
tag = data.get("tag_name")
|
return (data.get("tag_name") or None, None)
|
||||||
return tag or None
|
except urllib.error.HTTPError as exc:
|
||||||
|
return (None, AUTH if exc.code in (401, 403) else NETWORK)
|
||||||
except Exception:
|
except Exception:
|
||||||
return None
|
return (None, NETWORK)
|
||||||
|
|
||||||
|
|
||||||
|
def check_latest(timeout: float = 5.0) -> str | None:
|
||||||
|
"""Convenience: latest tag or None (ignores error reason)."""
|
||||||
|
tag, _ = fetch_latest(timeout)
|
||||||
|
return tag
|
||||||
|
|
||||||
|
|
||||||
|
def update_state(timeout: float = 5.0) -> tuple[str, str | None]:
|
||||||
|
"""Return (state, tag). state in NO_TOKEN/AUTH/NETWORK/UP_TO_DATE/AVAILABLE."""
|
||||||
|
tag, error = fetch_latest(timeout)
|
||||||
|
if error:
|
||||||
|
return (error, None)
|
||||||
|
if tag and is_newer(tag):
|
||||||
|
return (AVAILABLE, tag)
|
||||||
|
return (UP_TO_DATE, tag)
|
||||||
|
|||||||
@@ -123,17 +123,22 @@ class MainWindow(QMainWindow):
|
|||||||
return bar
|
return bar
|
||||||
|
|
||||||
def _check_updates(self) -> None:
|
def _check_updates(self) -> None:
|
||||||
self._update_checked.emit(updates.check_latest())
|
self._update_checked.emit(updates.update_state())
|
||||||
|
|
||||||
def _show_update_state(self, latest) -> None:
|
def _show_update_state(self, result) -> None:
|
||||||
if not latest:
|
state, tag = result
|
||||||
|
self._update_btn.setVisible(False)
|
||||||
|
if state == updates.NO_TOKEN:
|
||||||
|
self._update_label.setText("connect to update server")
|
||||||
|
elif state == updates.AUTH:
|
||||||
|
self._update_label.setText("update access denied")
|
||||||
|
elif state == updates.NETWORK:
|
||||||
self._update_label.setText("update check unavailable")
|
self._update_label.setText("update check unavailable")
|
||||||
return
|
elif state == updates.AVAILABLE:
|
||||||
if updates.is_newer(latest, __version__):
|
self._update_label.setText(f'<span style="color:{GOOD};">{tag} available</span>')
|
||||||
self._update_label.setText(f'<span style="color:{GOOD};">{latest} available</span>')
|
self._update_btn.setText(f"Update to {tag}")
|
||||||
self._update_btn.setText(f"Update to {latest}")
|
|
||||||
self._update_btn.setVisible(True)
|
self._update_btn.setVisible(True)
|
||||||
else:
|
else: # UP_TO_DATE
|
||||||
self._update_label.setText("up-to-date")
|
self._update_label.setText("up-to-date")
|
||||||
|
|
||||||
def _placeholder_page(self, title: str, description: str) -> QWidget:
|
def _placeholder_page(self, title: str, description: str) -> QWidget:
|
||||||
|
|||||||
@@ -4,11 +4,13 @@ from __future__ import annotations
|
|||||||
|
|
||||||
import threading
|
import threading
|
||||||
|
|
||||||
from PySide6.QtCore import Qt, Signal
|
from PySide6.QtCore import Qt, QUrl, Signal
|
||||||
|
from PySide6.QtGui import QDesktopServices
|
||||||
from PySide6.QtWidgets import (
|
from PySide6.QtWidgets import (
|
||||||
QFrame,
|
QFrame,
|
||||||
QHBoxLayout,
|
QHBoxLayout,
|
||||||
QLabel,
|
QLabel,
|
||||||
|
QLineEdit,
|
||||||
QPushButton,
|
QPushButton,
|
||||||
QSizePolicy,
|
QSizePolicy,
|
||||||
QTextEdit,
|
QTextEdit,
|
||||||
@@ -16,8 +18,9 @@ from PySide6.QtWidgets import (
|
|||||||
QWidget,
|
QWidget,
|
||||||
)
|
)
|
||||||
|
|
||||||
from ..core import installer, sysenv
|
from .. import config
|
||||||
from .theme import GOOD, MUTED
|
from ..core import installer, sysenv, updates
|
||||||
|
from .theme import GOOD, MUTED, WARN
|
||||||
|
|
||||||
|
|
||||||
def _panel(title: str) -> tuple[QFrame, QVBoxLayout]:
|
def _panel(title: str) -> tuple[QFrame, QVBoxLayout]:
|
||||||
@@ -33,13 +36,23 @@ def _panel(title: str) -> tuple[QFrame, QVBoxLayout]:
|
|||||||
return frame, layout
|
return frame, layout
|
||||||
|
|
||||||
|
|
||||||
|
_BACKEND_DESC = {
|
||||||
|
"env": "token from $RIGDOCTOR_TOKEN",
|
||||||
|
"keyring": "token stored in the OS keyring (encrypted)",
|
||||||
|
"file": "token stored in a 0600 file — install libsecret-tools to encrypt it",
|
||||||
|
"none": "no token saved",
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
class SetupPage(QWidget):
|
class SetupPage(QWidget):
|
||||||
_installed = Signal(int, str)
|
_installed = Signal(int, str)
|
||||||
|
_upd_state = Signal(object)
|
||||||
|
|
||||||
def __init__(self) -> None:
|
def __init__(self) -> None:
|
||||||
super().__init__()
|
super().__init__()
|
||||||
self.setObjectName("Page")
|
self.setObjectName("Page")
|
||||||
self._installed.connect(self._on_installed)
|
self._installed.connect(self._on_installed)
|
||||||
|
self._upd_state.connect(self._on_upd_state)
|
||||||
|
|
||||||
root = QVBoxLayout(self)
|
root = QVBoxLayout(self)
|
||||||
root.setContentsMargins(20, 18, 20, 18)
|
root.setContentsMargins(20, 18, 20, 18)
|
||||||
@@ -71,6 +84,27 @@ class SetupPage(QWidget):
|
|||||||
comp_layout.addLayout(controls)
|
comp_layout.addLayout(controls)
|
||||||
root.addWidget(comp_card)
|
root.addWidget(comp_card)
|
||||||
|
|
||||||
|
# Update access (M13): token gating updates to Gitea account holders.
|
||||||
|
upd_card, upd_layout = _panel("Update access")
|
||||||
|
self._upd_status = QLabel("")
|
||||||
|
self._upd_status.setObjectName("Muted")
|
||||||
|
self._upd_status.setWordWrap(True)
|
||||||
|
upd_layout.addWidget(self._upd_status)
|
||||||
|
token_row = QHBoxLayout()
|
||||||
|
self._token_input = QLineEdit()
|
||||||
|
self._token_input.setEchoMode(QLineEdit.EchoMode.Password)
|
||||||
|
self._token_input.setPlaceholderText("Paste a Gitea token (scope: read:repository)")
|
||||||
|
save_btn = QPushButton("Save token")
|
||||||
|
save_btn.setObjectName("PrimaryButton")
|
||||||
|
save_btn.clicked.connect(self._save_token)
|
||||||
|
get_btn = QPushButton("Get a token")
|
||||||
|
get_btn.clicked.connect(lambda: QDesktopServices.openUrl(QUrl(updates.TOKEN_PAGE)))
|
||||||
|
token_row.addWidget(self._token_input, 1)
|
||||||
|
token_row.addWidget(save_btn)
|
||||||
|
token_row.addWidget(get_btn)
|
||||||
|
upd_layout.addLayout(token_row)
|
||||||
|
root.addWidget(upd_card)
|
||||||
|
|
||||||
self._output = QTextEdit()
|
self._output = QTextEdit()
|
||||||
self._output.setObjectName("Report")
|
self._output.setObjectName("Report")
|
||||||
self._output.setReadOnly(True)
|
self._output.setReadOnly(True)
|
||||||
@@ -80,6 +114,7 @@ class SetupPage(QWidget):
|
|||||||
root.addStretch(1)
|
root.addStretch(1)
|
||||||
|
|
||||||
self._refresh()
|
self._refresh()
|
||||||
|
self._refresh_update_status()
|
||||||
|
|
||||||
def _refresh(self) -> None:
|
def _refresh(self) -> None:
|
||||||
self._env.setText(
|
self._env.setText(
|
||||||
@@ -126,3 +161,40 @@ class SetupPage(QWidget):
|
|||||||
self._output.setPlainText(out[-4000:])
|
self._output.setPlainText(out[-4000:])
|
||||||
self._install_btn.setText("Install missing")
|
self._install_btn.setText("Install missing")
|
||||||
self._refresh()
|
self._refresh()
|
||||||
|
# If libsecret-tools was just installed, move a file token into the keyring.
|
||||||
|
if config.token_backend() == "file" and config.keyring_available():
|
||||||
|
token = config.load_token()
|
||||||
|
if token:
|
||||||
|
config.save_token(token)
|
||||||
|
self._refresh_update_status()
|
||||||
|
|
||||||
|
# --- update access (token) ------------------------------------------------
|
||||||
|
def _save_token(self) -> None:
|
||||||
|
token = self._token_input.text().strip()
|
||||||
|
if not token:
|
||||||
|
return
|
||||||
|
config.save_token(token)
|
||||||
|
self._token_input.clear()
|
||||||
|
self._refresh_update_status()
|
||||||
|
|
||||||
|
def _refresh_update_status(self) -> None:
|
||||||
|
self._upd_status.setText(f"{_BACKEND_DESC[config.token_backend()]} · checking…")
|
||||||
|
threading.Thread(target=self._check_update, daemon=True).start()
|
||||||
|
|
||||||
|
def _check_update(self) -> None:
|
||||||
|
self._upd_state.emit((config.token_backend(), updates.update_state()))
|
||||||
|
|
||||||
|
def _on_upd_state(self, result) -> None:
|
||||||
|
backend, (state, tag) = result
|
||||||
|
msg = {
|
||||||
|
updates.NO_TOKEN: "paste a token below to enable updates",
|
||||||
|
updates.AUTH: "token rejected — check its scope/permissions",
|
||||||
|
updates.NETWORK: "couldn't reach the update server",
|
||||||
|
updates.UP_TO_DATE: f"up to date ({tag})" if tag else "up to date",
|
||||||
|
updates.AVAILABLE: f"update available: {tag}",
|
||||||
|
}[state]
|
||||||
|
color = GOOD if state == updates.AVAILABLE else (WARN if state == updates.AUTH else MUTED)
|
||||||
|
self._upd_status.setText(
|
||||||
|
f"<span style='color:{MUTED}'>{_BACKEND_DESC[backend]}</span> · "
|
||||||
|
f"<span style='color:{color}'>{msg}</span>"
|
||||||
|
)
|
||||||
|
|||||||
@@ -0,0 +1,36 @@
|
|||||||
|
"""Tests for update-token storage (file fallback + env override), keyring mocked out."""
|
||||||
|
|
||||||
|
import os
|
||||||
|
import tempfile
|
||||||
|
import unittest
|
||||||
|
from pathlib import Path
|
||||||
|
from unittest import mock
|
||||||
|
|
||||||
|
from rigdoctor import config
|
||||||
|
|
||||||
|
|
||||||
|
class TokenStorageTests(unittest.TestCase):
|
||||||
|
def test_file_fallback_roundtrip(self):
|
||||||
|
with tempfile.TemporaryDirectory() as d:
|
||||||
|
token_file = Path(d) / "token"
|
||||||
|
with mock.patch.object(config, "_secret_tool", return_value=None), \
|
||||||
|
mock.patch.object(config, "TOKEN_FILE", token_file), \
|
||||||
|
mock.patch.dict(os.environ, {}, clear=True):
|
||||||
|
self.assertIsNone(config.load_token())
|
||||||
|
config.save_token("abc123")
|
||||||
|
self.assertEqual(config.load_token(), "abc123")
|
||||||
|
self.assertEqual(config.token_backend(), "file")
|
||||||
|
self.assertEqual(token_file.stat().st_mode & 0o777, 0o600)
|
||||||
|
config.clear_token()
|
||||||
|
self.assertIsNone(config.load_token())
|
||||||
|
self.assertEqual(config.token_backend(), "none")
|
||||||
|
|
||||||
|
def test_env_override_wins(self):
|
||||||
|
with mock.patch.object(config, "_secret_tool", return_value=None), \
|
||||||
|
mock.patch.dict(os.environ, {"RIGDOCTOR_TOKEN": "envtok"}, clear=True):
|
||||||
|
self.assertEqual(config.load_token(), "envtok")
|
||||||
|
self.assertEqual(config.token_backend(), "env")
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
unittest.main()
|
||||||
Reference in New Issue
Block a user